[BOLT] Use llvm::max_element (NFC) #140342
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kazutakahirata
requested review from
aaupov,
ayermolo,
maksfb,
rafaelauler and
yota9
as code owners
Member
|
@llvm/pr-subscribers-bolt Author: Kazu Hirata (kazutakahirata) ChangesFull diff: https://github.com/llvm/llvm-project/pull/140342.diff 1 Files Affected:
diff --git a/bolt/lib/Passes/PettisAndHansen.cpp b/bolt/lib/Passes/PettisAndHansen.cpp
index f138c609b689a..ab466ab47dcb0 100644
--- a/bolt/lib/Passes/PettisAndHansen.cpp
+++ b/bolt/lib/Passes/PettisAndHansen.cpp
@@ -143,11 +143,10 @@ std::vector<Cluster> pettisAndHansen(const CallGraph &Cg) {
// Find an arc with max weight and merge its nodes
while (!Carcs.empty()) {
- auto Maxpos =
- std::max_element(Carcs.begin(), Carcs.end(),
- [&](const ClusterArc &Carc1, const ClusterArc &Carc2) {
- return Carc1.Weight < Carc2.Weight;
- });
+ auto Maxpos = llvm::max_element(
+ Carcs, [&](const ClusterArc &Carc1, const ClusterArc &Carc2) {
+ return Carc1.Weight < Carc2.Weight;
+ });
ClusterArc Max = *Maxpos;
Carcs.erase(Maxpos);
|
aaupov
approved these changes
May 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.